Clarify that the test-suite is not a style guide. #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Shristibot please refrain from just opening PRs. I see that you have requested to be assigned to the isue, but you have not actually been assigned this work. This is the second time I've mentioned to you about our process. |
Contributor
Author
Thank you for the clarification, and sorry for the oversight. I understand the assignment process now and will ensure I follow it correctly moving forward |
jdesrosiers
requested changes
Jan 5, 2026
Co-authored-by: Jason Desrosiers <[email protected]>
jdesrosiers
approved these changes
Jan 5, 2026
jdesrosiers
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the purpose of the JSON Schema Test Suite by explicitly stating that it is intended to verify behaviour defined by the specification, not to serve as a style guide or a set of recommended schema patterns.
The goal is to reduce confusion for both schema authors and implementors by making it clear that the presence of a test does not imply best practice, only that the behaviour is specified.
Fixes #324