Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template to announce implementations #568

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Jan 5, 2024

GitHub Issue: # / NA

Summary: Add a template to promote new implementations added to the Implementations page.

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but should this file just be templates.md in the folder one level up? It contains multiple templates in one file (which I think is the right thing to do).

adopters also looks like it needs updating in the same way.

Otherwise, this looks great. Thanks for doing this work.

@benjagm
Copy link
Collaborator Author

benjagm commented Jan 11, 2024

Nitpick, but should this file just be templates.md in the folder one level up? It contains multiple templates in one file (which I think is the right thing to do).

I think is better one single file with all the promotion messages. What I can do is rename the file from tweet-template.md to promotion-template.md or promotion-templates.md

@Relequestual
Copy link
Member

I agree that one file is best. I just think the name of the file needs to change.
Agreed =]

@benjagm
Copy link
Collaborator Author

benjagm commented Jan 12, 2024

I agree that one file is best. I just think the name of the file needs to change.

I renamed all the templates for all the programs.

@benjagm benjagm requested a review from Relequestual January 12, 2024 09:48
@benjagm
Copy link
Collaborator Author

benjagm commented Jan 16, 2024

Nitpick, but should this file just be templates.md in the folder one level up? It contains multiple templates in one file (which I think is the right thing to do).

adopters also looks like it needs updating in the same way.

Otherwise, this looks great. Thanks for doing this work.

Done.

@benjagm benjagm merged commit 6e7f09b into main Jan 24, 2024
@benjagm benjagm deleted the benjagm-implementers-template branch January 24, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants