-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Damodharan J as an ambassador #823
base: main
Are you sure you want to change the base?
Conversation
Thanks a lot for your interest in becoming a JSON Schema Ambassador!! Your articles are very cool! I'll ask the TSC for their vote but you have mine. |
Thanks a lot @benjagm! Looking forward! |
I'm sorry for the delay. I'd like to go through the articles, and I haven't had time. |
Hi @gregsdennis! Please look at the articles and if there are issues, just let me know anytime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work you've submitted is impressive, but it's tightly coupled with a specific implementation and one that we typically recommend avoiding in favor of Jason's hyperjump. (We recommend that if you use ajv, you do so only with "strict" mode off to enforce compatibility.)
You've shown that you understand JSON Schema, which is great, but being an ambassador requires community involvement, which isn't something I've seen from you.
I'm sorry, but I can't approve this appointment at this time.
Thanks a lot for the feedback @gregsdennis 🙂!
Sure, have made the changes stating about "strict" mode as recommended usage mode. None of the examples require hyperjump.
I m giving a tech talk on JSONSchema as runtime typesystem. Also we have adopted JSONSchema in all of the stack (frontend & backend ) of Phaged XPlain & If there is anything else that would help me i would like try. |
I think you've misunderstood. This is the line you added to your articles.
The JSON Schema specification doesn't have a "strict mode". "Strict mode" is an ajv concept. By default, ajv violates the JSON Schema specification in several ways. In order to get fully JSON Schema compliant behavior when using ajv, you need to use ajv's strict mode. So, for the articles that don't mention ajv, I suggest removing this note. For the articles that do mention ajv, please fix the note to make it clear this is an ajv problems, not a JSON Schema problem. |
Thanks a lot for the input. Have made the changes in the required articles. |
@damodharanj Someone brought up that there's still an issue with your ajv disclaimers. I think this is partially my fault due to a typo in my previous message. I even reviewed the changes and didn't notice that it was backwards. Strict mode in ajv is turned ON by default and must be turned OFF in order to be spec compliant. Please make the correction and I'm sorry for inadvertently telling you the wrong thing. |
I have the made the changes about ajv in the relevant articles. Thanks for the review! |
Hey @damodharanj - The recommendation is to turn Strict Mode OFF. It is ON by default. Thanks for your articles and best of luck with your talk! |
My bad. Oh got it now! I have made changes to the articles as per the suggestion.
Thanks a ton @Relequestual ! Looking forward to presenting my experience working with JSONSchema and would share the feedback I get |
Hello all!
Can I add this to this application as well ? |
Hello community,
These are my contributions and will also be giving a tech talk on "JSONSchema - Runtime type-system". Looking forward to contribute as an ambassador.
Please let me know if I have to do anything further.