Skip to content

Update configuration and fix deprecation warnings related to charlists #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

m0to
Copy link

@m0to m0to commented Mar 6, 2025

  • Update config.exs to current specification using import Config
  • Update single quoted charlists to use the character sigil
  • Improve pid validation in xlsx_file.ex
  • Add explicit conversion of paths to charlist in unzip.ex
  • ran mix format on all files

@jamesvl
Copy link

jamesvl commented Jul 3, 2025

I'm hopeful the maintainer here will pick this up and keep the package up to date.

In the mean time, I prefer to have less compiler warnings and bugs vs. more, so I've forked and then merged in your MR to the main branch of https://github.com/Semsee/xlsxir

I've also run mix deps.update --all and verified unit tests are still passing. Since my organization is using this package I'm happy to maintain things there for the foreseeable future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants