Code review #2
Open
Code review #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented schnorr signature algorithm
* Got crypto primatives working
* Added a couple unit test stubs
* Added network_id to signer context
* Implemented roinput add_field
* Started on blinding hash implementation
* Implemented loading keypair from secret key hex
* Implemented address generation
* Added keypair unit tests
* Work in progress on ROInput add_scalar
* Created field and scalar helpers and unit tests
* Simplified keypair deserialization, added unit tests
* Implemented add_scalar, add_bit and add_bytes for ROInput
* Implemented some ROInput unit tests
* Moved Transaction and Notarization to tests module
* Implemented ROInput add_u32 and add_u64
* Finished ROInput bits unit tests
* Added scalar to_string method
* Implemented ROInput to_bytes
* Added some ROInput::to_bytes unit tests
* Implemented ROInput::to_fields serialization
* Renamed add_ to append_
* Added simple from_bytes for field elements
* Created to_field serialization unit tests
* Added compressed private key struct and helpers
* Added mina transaction struct for unit testing
* Implemented random oracle input serialization for transaction struct
* Added new payment transaction API (with builder pattern)
* Added pubkey module
* Moved Mina address creation into PubKeyHelper
* Simplified double-sha256 calls
* Implemented safe memo_str()
* Added memo unit tests
* Implemented CompressedPubKey decompression
* Implemented PubKey::from_address(), Mina address -> PubKey
* Added PubKey::from_address() unit tests
* Added CompressedPubKey::to_address()
* Added Signature::to_string()
* Bugfix to transaction memo (don't forget prefix)
* Updated memo unit tests
* Switch from from 64- to 32-byte blake2b output
* Check whether field element is odd in a better way
* Added domain_prefix to Input interface
* Implemented prefix hashing for domain separation (initial poseidon sponge state)
* Added support for testing delegation transaction signing
* Implemented equality and debug for Signature struct
* Imported all payment and delegation signature unit tests
from other signer implementations
* Cleanup debug code
* Make signer context reusable for multiple signatures
* Simplify Input interface
* Added verify to signer interface
* Implemented Mina Schnorr verifier
* Added verification unit tests
mimoo
reviewed
Nov 18, 2021
|
Thanks David for awesome code review! |
|
Do you think |
|
yeah I think these would be nice to have in |
Cool - I will try to do that as part of the merge over to proof-systems |
* This really doesn't belong in the FieldHelpers which
should be agnostic to this
* Update all the unit tests
…nt types
* Remove ScalarHelpers and made FieldHelpers generic
* Renamed library with a more specific name
* Hashable is for code that only wants to hash
* Added comments and documentation
* This provides flexibility to extend things in future and useful customization
* Disable Debug and Display for SecKey
* Keypair Debug and Display only show public key part
* Merged PubKeyHelpers into PubKey implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.