Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes redundant modules app-domain and test-domain #128

Merged
merged 3 commits into from
Oct 7, 2017
Merged

Removes redundant modules app-domain and test-domain #128

merged 3 commits into from
Oct 7, 2017

Conversation

vbekiaris
Copy link
Contributor

The first commit removes app-domain module, moving its classes to cache-tests module.
The second commit removes test-domain module, its classes & resources moved in cache-tests module.
The third commit removes unused class Zoo.

Fixes #92

vbekiaris added 3 commits May 11, 2017 18:05
@vbekiaris
Remove app-domain module
5f6e7ab
@vbekiaris
Removes test-domain module
e717659 
Moves beans from test-domain to cache-tests
Test harnesses that depended on test-domain now depend on cache-tests
@vbekiaris
Removes unused class
3ea933c
@vbekiaris vbekiaris added this to the 1.1.0 milestone May 12, 2017
@vbekiaris vbekiaris self-assigned this May 12, 2017
@vbekiaris
Copy link
Contributor Author

@cruftex could you please review?

@cruftex
Copy link
Member

cruftex commented Jul 13, 2017

That's hard to review in the diff, but looks okay to me. Pls. double check that there are the same number of tests and everything runs through fine.

@vbekiaris
Copy link
Contributor Author

Both master and this patch yield the same test results:

specific-implementation-tester:
Tests run: 472, Failures: 0, Errors: 0, Skipped: 0

cdi-annotations-tester:
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0

spring-annotations-tester:
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0

guice-annotations-tester:
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0

@vbekiaris vbekiaris requested a review from cruftex October 7, 2017 16:29
cruftex
cruftex approved these changes Oct 7, 2017
View reviewed changes
Copy link
Member

@cruftex cruftex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vbekiaris vbekiaris merged commit 666b1e5 into jsr107:master Oct 7, 2017
@vbekiaris vbekiaris deleted the fixes/1.1/remove-redundant-modules branch October 7, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cruftex cruftex cruftex approved these changes

Assignees

@vbekiaris vbekiaris

Labels
Refactoring
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vbekiaris @cruftex