[Fix] jsx-no-constructed-context-values: detect constructed context values in React 19 <Context> usage
#3910
+165
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… values in React 19 `<Context>` usage
2 tasks
TildaDares
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3910 +/- ##
==========================================
+ Coverage 94.21% 97.80% +3.59%
==========================================
Files 133 133
Lines 9966 9991 +25
Branches 3703 3715 +12
==========================================
+ Hits 9389 9772 +383
+ Misses 577 219 -358 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The codecov check is stuck, so I can't confirm if the coverage has improved. Is there a way to rerun it without pushing code? |
TildaDares
force-pushed
the
jsx-no-constructed-context-react19
branch
from
1fe341a to
b81c370
Compare
ljharb
force-pushed
the
jsx-no-constructed-context-react19
branch
from
b81c370 to
ddefdce
Compare
|
I had to rebase it anyways, so no worries :-) hopefully it won't be stuck this time. Thanks! |
ljharb
approved these changes
Mar 25, 2025
ljharb
changed the title
jsx-no-constructed-context-values: detect constructed context values in React 19 <Context> usage
ljharb
reviewed
Mar 25, 2025
TildaDares
force-pushed
the
jsx-no-constructed-context-react19
branch
from
5bf8e89 to
08d3ac8
Compare
ljharb
force-pushed
the
jsx-no-constructed-context-react19
branch
3 times, most recently
from
2f3afb0 to
2428618
Compare
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Apr 4, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | eslint-plugin-react | 7.37.4 | 7.37.5 | ## [v7.37.5](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7375---20250403) ##### Fixed - \[`no-unknown-property`]: allow shadow root attrs on `<template>` ([#3912][] [@ljharb](https://github.com/ljharb)) - \[`prop-types`]: support `ComponentPropsWithRef` from a namespace import ([#3651][] [@corydeppen](https://github.com/corydeppen)) - \[`jsx-no-constructed-context-values`]: detect constructed context values in React 19 `<Context>` usage ([#3910][] [@TildaDares](https://github.com/TildaDares)) - \[`no-unknown-property`]: allow `transform-origin` on `rect` ([#3914][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[Docs] \[`button-has-type`]: clean up phrasing ([#3909][] [@hamirmahal](https://github.com/hamirmahal)) [7.37.5]: jsx-eslint/eslint-plugin-react@v7.37.4...v7.37.5 [#3914]: jsx-eslint/eslint-plugin-react#3914 [#3912]: jsx-eslint/eslint-plugin-react#3912 [#3910]: jsx-eslint/eslint-plugin-react#3910 [#3909]: jsx-eslint/eslint-plugin-react#3909 [#3651]: jsx-eslint/eslint-plugin-react#3651
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Apr 5, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | eslint-plugin-react | 7.37.4 | 7.37.5 | ## [v7.37.5](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7375---20250403) ##### Fixed - \[`no-unknown-property`]: allow shadow root attrs on `<template>` ([#3912][] [@ljharb](https://github.com/ljharb)) - \[`prop-types`]: support `ComponentPropsWithRef` from a namespace import ([#3651][] [@corydeppen](https://github.com/corydeppen)) - \[`jsx-no-constructed-context-values`]: detect constructed context values in React 19 `<Context>` usage ([#3910][] [@TildaDares](https://github.com/TildaDares)) - \[`no-unknown-property`]: allow `transform-origin` on `rect` ([#3914][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[Docs] \[`button-has-type`]: clean up phrasing ([#3909][] [@hamirmahal](https://github.com/hamirmahal)) [7.37.5]: jsx-eslint/eslint-plugin-react@v7.37.4...v7.37.5 [#3914]: jsx-eslint/eslint-plugin-react#3914 [#3912]: jsx-eslint/eslint-plugin-react#3912 [#3910]: jsx-eslint/eslint-plugin-react#3910 [#3909]: jsx-eslint/eslint-plugin-react#3909 [#3651]: jsx-eslint/eslint-plugin-react#3651
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Apr 6, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ------ | | npm | eslint-plugin-react | 7.37.4 | 7.37.5 | ## [v7.37.5](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7375---20250403) ##### Fixed - \[`no-unknown-property`]: allow shadow root attrs on `<template>` ([#3912][] [@ljharb](https://github.com/ljharb)) - \[`prop-types`]: support `ComponentPropsWithRef` from a namespace import ([#3651][] [@corydeppen](https://github.com/corydeppen)) - \[`jsx-no-constructed-context-values`]: detect constructed context values in React 19 `<Context>` usage ([#3910][] [@TildaDares](https://github.com/TildaDares)) - \[`no-unknown-property`]: allow `transform-origin` on `rect` ([#3914][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[Docs] \[`button-has-type`]: clean up phrasing ([#3909][] [@hamirmahal](https://github.com/hamirmahal)) [7.37.5]: jsx-eslint/eslint-plugin-react@v7.37.4...v7.37.5 [#3914]: jsx-eslint/eslint-plugin-react#3914 [#3912]: jsx-eslint/eslint-plugin-react#3912 [#3910]: jsx-eslint/eslint-plugin-react#3910 [#3909]: jsx-eslint/eslint-plugin-react#3909 [#3651]: jsx-eslint/eslint-plugin-react#3651
jens-duttke
reviewed
Apr 8, 2025
| @@ -33,6 +43,11 @@ return ( | |||
| ) | |||
| ``` | |||
|
|
|||
| ```jsx | |||
| const SomeContext = createContext(); | |||
| const Component = () => <SomeContext value="Some string"><SomeContext>; | |||
There was a problem hiding this comment.
There's a slash missing in closing <SomeContext> -> </SomeContext>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3888
This PR updates the
jsx-no-constructed-context-valuesrule to support React 19-style context providers using the shorthand.