Add test for #1197 (#1269)

jtablesaw · Jan 3, 2025 · 3c443ed · 3c443ed
1 parent a923338
commit 3c443ed
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/core/src/main/java/tech/tablesaw/io/FileReader.java b/core/src/main/java/tech/tablesaw/io/FileReader.java
@@ -137,12 +137,13 @@ private void renameDuplicateColumnHeaders(String[] headerNames) {
     Map<String, Integer> nameCounter = new HashMap<>();
     for (int i = 0; i < headerNames.length; i++) {
       String name = headerNames[i];
-      Integer count = nameCounter.get(name.toLowerCase());
+      String lowerCase = name.toLowerCase();
+      Integer count = nameCounter.get(lowerCase);
       if (count == null) {
-        nameCounter.put(name.toLowerCase(), 1);
+        nameCounter.put(lowerCase, 1);
       } else {
         count++;
-        nameCounter.put(name.toLowerCase(), count);
+        nameCounter.put(lowerCase, count);
         headerNames[i] = name + "-" + count;
       }
     }

diff --git a/core/src/test/java/tech/tablesaw/io/csv/CsvReaderTest.java b/core/src/test/java/tech/tablesaw/io/csv/CsvReaderTest.java
@@ -161,6 +161,17 @@ void allowDuplicateColumnNames() throws IOException {
     assertEquals("Col1-2", dupes.columnNames().get(1));
   }
 
+  @Test
+  void allowDuplicateColumnNamesInsensitive() {
+    Reader reader2 =
+        new StringReader(
+            "Col1" + COMMA + "col1" + LINE_END + "first" + COMMA + "second" + LINE_END);
+    Table dupes =
+        Table.read().csv(CsvReadOptions.builder(reader2).allowDuplicateColumnNames(true).build());
+    assertEquals("Col1", dupes.columnNames().get(0));
+    assertEquals("col1-2", dupes.columnNames().get(1));
+  }
+
   @Test
   public void testWithColumnSKIPWithoutHeader() throws IOException {
     // Read the CSV file