Avoid potential int overflow #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Jan 3, 2025
| @@ -362,7 +362,7 @@ public static int plusYears(int yearsToAdd, int packedDate) { | |||
| byte m = getMonthValue(packedDate); | |||
| short y = getYear(packedDate); | |||
|
|
|||
| int newYear = YEAR.checkValidIntValue(yearsToAdd + y); | |||
| int newYear = YEAR.checkValidIntValue((long)yearsToAdd + y); | |||
There was a problem hiding this comment.
Suggested change
| int newYear = YEAR.checkValidIntValue((long)yearsToAdd + y); | |
| int newYear = YEAR.checkValidIntValue((long) yearsToAdd + y); |
There was a problem hiding this comment.
@ccleva if you allow edits from maintainers I could merge this PR
There was a problem hiding this comment.
Oh I completely missed that option, will do thanks
There was a problem hiding this comment.
This option is not available for PR from an organization repo... https://github.com/orgs/community/discussions/5634.
I'll switch back to working with a personal fork when possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
Avoid potential int overflow in PackedLocalDate.plusYears
Testing
No