Fix tests

[ccleva]

Thanks for contributing.

• Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

Description

• Correct DataFrameJoinerTest.leftOuterEmptyLeftTable to use JoinType.LEFT_OUTER instead of the default INNER - inner join is tested in innerJoinEmptyLeftTable
• Added assertions in AggregateFunctionsTest.testMultipleColumnTypes and DoubleArraysTest.testTo2dArray

Testing

Did you add a unit test?

[benmccann]

Can you rebase this PR to make sure the formatter runs against it now that the formatter's been fixed?

[ccleva]

I rebased it without issue in local, but the new formatter gives me an error related to jvm version with both eclipse and command line. I need to see how to fix this before any other contribution.

[benmccann]

Hmm. That's too bad. I have Java 11 installed for java and javac. What version do you have? I'd hate if it's causing issues for everyone who wants to contribute

[ccleva]

Hmm. That's too bad. I have Java 11 installed for java and javac. What version do you have? I'd hate if it's causing issues for everyone who wants to contribute

I'm using java 17 for command line, and latest eclipse requires (and provides) java 21. The issue happens for java 16+, see https://github.com/Cosium/git-code-format-maven-plugin?tab=readme-ov-file#jdk-16-peculiarities.

The recommended configuration solves the issue. This should be documented somewhere for contributors using java 16+.

[ccleva]

Rebased, commit hooks ran, and force-pushed. Should be fine now.

[benmccann]

This should be documented somewhere for contributors using java 16+.

Agreed. Is this something we can update in the pom.xml or it should just go in the CONTRIBUTING.md? Either way, mind sending a PR for that? You're better able to test it since you're on a newer Java than I am

[ccleva]

Agreed. Is this something we can update in the pom.xml or it should just go in the CONTRIBUTING.md? Either way, mind sending a PR for that? You're better able to test it since you're on a newer Java than I am

You have to add jvm options to maven, typically in the .mvn/jvm.config file in the repo. Would you prefer a commented-out option file in the repo and the documentation stating it needs to be uncommented for java 16+, or only the description of what needs to be done ? In any case CONTRIBUTING.md seems the right place.

[benmccann]

I wonder if we can just add that file and leave it uncommented. Hopefully it won't have any ill effects for Java 11 users. I could test that if you share the file

[ccleva]

I'll make a PR like you suggest, if it does not work with java 11 we will explore other options

[ccleva]

Done in #1280. It did not make the builds with java 11 fail, but I would be more confident if you test it in local.