Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty csv test #1274

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Fix empty csv test #1274

merged 3 commits into from
Jan 3, 2025

Conversation

ccleva
Copy link
Contributor

@ccleva ccleva commented Jan 3, 2025

Thanks for contributing.

Description

  • Fix CSVReaderTest.testEmptyFileHeaderEnabled by enabling header - disabled header tested in testEmptyFileHeaderDisabled
  • Fix FileReader.getColumnNames to not throw NPE when header is enabled and file is empty

Testing

Fixed one

@ccleva ccleva mentioned this pull request Jan 3, 2025
Open
@benmccann benmccann merged commit c29a57e into jtablesaw:master Jan 3, 2025
6 checks passed
@ccleva ccleva deleted the fix_empty_csv_test branch January 3, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccleva @benmccann