Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table.melt method parameter changed from Boolean to boolean #1275

Merged

Conversation

ccleva
Copy link
Contributor

@ccleva ccleva commented Jan 3, 2025

Thanks for contributing.

Description

The dropMissing parameter in Table.melt is defined as a Boolean but used and tested as a boolean. Changed to boolean to avoid potential NPE.

Testing

Did you add a unit test?

@benmccann benmccann merged commit 5efb947 into jtablesaw:master Jan 3, 2025
7 checks passed
@ccleva ccleva deleted the fix_potential_NPE_in_Table_melt branch January 3, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants