hummingbird: bidirectional reservations#64
Merged
Conversation
Simplified Reservation construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for bidirectional reservations.
A bidirectional reservation doesn't exist in Hummingbird. The reservations in Hummingbird are unidirectional.
This PR adds the ability of sending a preexisting Hummingbird reservation to the destination,
so that the destination can unpack it and use it as a path in the reply packets.
The typical scenario for this feature is communication between a client and a server.
The client would request a regular, forward reservation from the client to the server.
Additionally, the client could also request the reverse reservation, i.e. from the server to the client,
so that the server would use it to reply to the client.
The reverse reservation information is carried inside an end to end extension header,
typically only once (as the packets are QoS protected by the forward reservation).
The server just needs to unpack this information and recreate the reverse reservation.
The server needs to keep in memory this reservation, at least for its valid lifetime,
or until a new reverse reservation is sent by the client.
The setup of a bidirectional reservation by the client is easy.
An extra parameter of
reverse bandwidthhas been added to theOneShotReservationhigh level API.
The server just needs to use the
HummReplyPatheras a reply pather.This change is