Reply pather per source#66
Merged
Merged
Conversation
TODO: - Support concurrency. - Cleanup map eventually. - Add unit tests for multiple clients. - Add unit tests for concurrency.
Still TODO: - Reject reverse rsvs. without flyovers.
Since they are not better than just reversing the current path, do not store them. If one of them is received as a reverse reservation, remove any existing previous reverse reservation for that particular source ID.
juagargi
commented
Jul 13, 2026
juagargi
left a comment
Owner
Author
There was a problem hiding this comment.
@juagargi reviewed 6 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on juagargi).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design of snet has one
ReplyPatherper SCION network object.The
snet.Connthat is obtained fromListenorDialcopies this reference to its ownConnobject.Additionally, there is only one
Connobject at the server, where it just obtains it afterListen,and simply reads all packets, obtaining the remote address as a return value of
ReadFrom.Since the
HummReplyPatherkeeps state per client, it has to do its own bookkeeping.For each
Packet, a client ID is obtained using the IA, IP, and UDP port in said packet.For each client ID, the
HummReplyPathercan keep a reverse reservation,if one was sent via an E2E extension header.
If the reverse reservation contains no flyovers, it is not stored; it doesn't offer better guarantees to the server than the reverse path used to carry the packet from the client to the server in the first place.
Thus it's equivalent to just reverse the regular forward path received at the server.
It would remove a previous reverse reservation for that client ID if there were any,
to make the equivalence truly complete.
This PR adds extensive tests covering the following features of the
HummReplyPather:SetStatefunction: the only place where the storage grows, now also ensures it can shrink.This change is