Hummingbird without endhostapi refactors - #70
Merged
juagargi merged 17 commits intoAug 20, 2026
Conversation
1 task
Reuse existing to hops path conversion helper.
Use a WithTx(). Use shared row scanners for asset and resevation. Use an enum for state transition. Add some tests for the new functionality.
Without the change, gazelle will look for the connect rpc endpoints being publicly published. The change makes gazelle use the local repository as the source of the needed dependencies for the specified packages.
juagargi
force-pushed
the
hummingbird-without-endhostapi-refactors
branch
from
August 10, 2026 14:51
d28deca to
785505e
Compare
They are indempotent now. Populate has a --default-values option, that populates with a set of predefined values. Two users, all ASes, all interfaces.
A primary key on a nullable field would allow the same user name to exist twice, as sqlite considers each NULL to be distinct.
The setup and populate scripts work with docker also, and the setup script switches to docker deployment if it detects it in the gen folder. Default port for the marketplace is now 31888. With the docker local topology, the marketplace lives in the same namespace as the CS, same IP address.
Define the bit width of the bandwidth field as a constant. Create a common encodeBandwidthWithLogStart function to be used by other packets via the public function EncodeBandwidth. Modify the token buckets to use it.
Bugs binding some arguments. Bugs AND'ing some non-parenthesized WHERE entries.
The delegation uses the same bandwidth encoding as encodeBandwidthWithLogStart.
juagargi
marked this pull request as ready for review
August 20, 2026 14:53
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does:
This change is