Skip to content

26.1.2#176

Open
ArikSquad wants to merge 4 commits into
juancarloscp52:mainfrom
ArikSquad:feat/26_1_2
Open

26.1.2#176
ArikSquad wants to merge 4 commits into
juancarloscp52:mainfrom
ArikSquad:feat/26_1_2

Conversation

@ArikSquad
Copy link
Copy Markdown

Implements 26.1.2 for Entropy.

Something I'm not absolutely sure about is the whether the fov changes are correct.

Copy link
Copy Markdown
Collaborator

@bl4ckscor3 bl4ckscor3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick partial review, skipped over the mixins and didn't do ingame testing yet.

Comment thread src/main/java/me/juancarloscp52/entropy/events/db/DeathSightEvent.java Outdated
Comment thread src/main/java/me/juancarloscp52/entropy/events/db/IntenseThunderStormEvent.java Outdated
Comment thread src/main/java/me/juancarloscp52/entropy/events/db/SkyBlockEvent.java Outdated
Comment thread src/main/java/me/juancarloscp52/entropy/events/db/TimelapseEvent.java Outdated
@ArikSquad
Copy link
Copy Markdown
Author

I'll apply those changes later, I played this with my friends for a couple hours and it worked great. Of course some minor behavioral mistakes, which I'll fix tomorrow

ArikSquad and others added 3 commits April 25, 2026 01:26
Co-authored-by: bl4ckscor3 <bl4ckscor33@gmail.com>
Co-authored-by: bl4ckscor3 <bl4ckscor33@gmail.com>
I changed it to use the programmatical way to do that, I don't immediately see why you wouldn't do it like this.
@ArikSquad ArikSquad requested a review from bl4ckscor3 April 27, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants