Skip to content

Commit

Permalink
Restrict annotation functionality to versions of Julia it works on (#79)
Browse files Browse the repository at this point in the history
* Restrict annotation functionality to versions of Julia it works on

see #76

* Update README.md
  • Loading branch information
ericphanson authored Apr 2, 2023
1 parent 4867b26 commit 1aec431
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ jobs:
You can add this workflow to your repository by placing it in a file called `test.yml` in the folder `.github/workflows/`. [More info here](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions).

Here, setting `annotate: true` causes GitHub "annotations" to appear when reviewing the PR, pointing to failing tests, if any.
Note that this impacts stacktraces in case of errors (see #76).
This functionality is only enabled on Julia 1.8 (even if `annotate` is set to `true`), since currently it does not work on other Julia versions (see #76).

By default, `annotate` is set to false, but that may change in future releases of this action.
### Prefixing the Julia command

Expand Down
3 changes: 2 additions & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ runs:
shell: bash
- name: Install dependencies in their own (shared) environment
run: |
if VERSION > v"1.8pre"
# Functionality only currently works on a narrow range of Julia versions... see #76
if v"1.8pre" < VERSION < v"1.9.0-beta3"
using Pkg
Pkg.activate("tests-logger-env"; shared=true)
Pkg.add(Pkg.PackageSpec(name="GitHubActions", version="0.1"))
Expand Down

0 comments on commit 1aec431

Please sign in to comment.