-
Notifications
You must be signed in to change notification settings - Fork 8
Integrate StaticLint and SymbolServer #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
davidanthoff
wants to merge
27
commits into
main
Choose a base branch
from
integrate-staticlint-symbolserver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: packages/JSONRPC git-subtree-split: 9e022c861a42677062dd015872aa16e4d45526d1
git-subtree-dir: packages/JSON git-subtree-split: 4b3913d58f04cc5bb2f8d23c6ef82e0fbed20525
git-subtree-dir: packages/CancellationTokens git-subtree-split: 9130370b57161b38d5a8b2bb0f947f60d7adc988
…CancellationTokens'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this will work out, but so far it seems fairly promising. The idea is that we just move the existing content of both packages in here so simplify development.
I also started to change StaticLint so that everything in the
metafield inEXPRis now stored in a side table, that makes everything work fairly nicely with the functional Salsa.jl approach.Still lots of stuff to do, though...