Draft
Conversation
…t broadcasting. So far he has fixed broadcasting for + and - and authored some new tests that pass.
Add broadcasting support for Convex.jl expressions (jump-dev#479)
…#479) Add broadcasted methods for -, abs, exp, log, sqrt, max, and min so that dot-syntax (e.g. abs.(expr), .-expr, max.(expr, val)) delegates to the existing non-broadcast implementations instead of failing with MethodError. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add broadcasting support for Convex.jl expressions (jump-dev#479)
…#479) Add size checks to all AbstractExpr-AbstractExpr broadcasted methods so that broadcast-compatible but different-sized expressions (e.g. (3,1) .+ (3,5)) fall back to DefaultArrayStyle instead of erroring in the Convex operator that requires matching sizes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…dev#479) Extend broadcast tests to cover cases where AbstractExpr operands have broadcast-compatible but different sizes (e.g. (1,4) .+ (2,4), (2,1) .+ (2,2)), verifying the DefaultArrayStyle fallback produces correct results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add some more tests
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 98.20% 97.43% -0.77%
==========================================
Files 88 88
Lines 5121 5234 +113
==========================================
+ Hits 5029 5100 +71
- Misses 92 134 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I'm not necessarily against something like this, but I need to think about it before merging. They may be a simpler option that works for all operators, like defining a different broadcast style. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude and I addressed issue #479 in the CVXPY Workshop hackathon by adding support and tests for broadcasting operations.
We also added a CLAUDE.md file for other developers using Claude.