add suggestion

jump-dev · Jan 14, 2025 · 91865cf · 91865cf
1 parent 24347f9
commit 91865cf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 23 deletions.
diff --git a/Project.toml b/Project.toml
@@ -22,6 +22,6 @@ IterativeSolvers = "0.9"
 JuMP = "1"
 LazyArrays = "0.21, 0.22, 1"
 MathOptInterface = "1.18"
-MathOptSetDistances = "0.2.7"
+MathOptSetDistances = "0.2.9"
 ParametricOptInterface = "0.9.0"
 julia = "1.6"
diff --git a/src/moi_wrapper.jl b/src/moi_wrapper.jl
@@ -39,7 +39,9 @@ function diff_optimizer(
     # For this reason we add a cache layer, the same cache JuMP adds.
     caching_opt = if with_cache
         MOI.Utilities.CachingOptimizer(
-            MOI.Utilities.UniversalFallback(MOI.Utilities.Model{with_bridge_type}()),
+            MOI.Utilities.UniversalFallback(
+                MOI.Utilities.Model{with_bridge_type}(),
+            ),
             optimizer,
         )
     else

diff --git a/src/parameters.jl b/src/parameters.jl
@@ -76,22 +76,22 @@ function SensitivityData{T}() where {T}
     )
 end
 
+const _SENSITIVITY_DATA = :_sensitivity_data
+
 function _get_sensitivity_data(
     model::POI.Optimizer{T},
 )::SensitivityData{T} where {T}
     _initialize_sensitivity_data!(model)
-    return model.ext[:_sensitivity_data]::SensitivityData{T}
+    return model.ext[_SENSITIVITY_DATA]::SensitivityData{T}
 end
 
 function _initialize_sensitivity_data!(model::POI.Optimizer{T}) where {T}
-    if !haskey(model.ext, :_sensitivity_data)
-        model.ext[:_sensitivity_data] = SensitivityData{T}()
+    if !haskey(model.ext, _SENSITIVITY_DATA)
+        model.ext[_SENSITIVITY_DATA] = SensitivityData{T}()
     end
     return
 end
 
-const DoubleDictInner = MOI.Utilities.DoubleDicts.DoubleDictInner
-
 # forward mode
 
 function _constraint_set_forward!(
@@ -280,7 +280,7 @@ end
 
 function empty_input_sensitivities!(model::POI.Optimizer{T}) where {T}
     empty_input_sensitivities!(model.optimizer)
-    model.ext[:_sensitivity_data] = SensitivityData{T}()
+    model.ext[_SENSITIVITY_DATA] = SensitivityData{T}()
     return
 end
 
@@ -304,21 +304,6 @@ function forward_differentiate!(model::POI.Optimizer{T}) where {T}
     return
 end
 
-# function MOI.set(
-#     model::POI.Optimizer,
-#     ::ForwardParameter,
-#     variable::MOI.VariableIndex,
-#     value::Number,
-# )
-#     if _is_variable(model, variable)
-#         error("Trying to set a forward parameter sensitivity for a variable")
-#     end
-#     parameter = variable
-#     sensitivity_data = _get_sensitivity_data(model)
-#     sensitivity_data.parameter_input_forward[parameter] = value
-#     return
-# end
-
 function MOI.set(
     model::POI.Optimizer,
     ::ForwardConstraintSet,