Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110
Closes #108
Another quite large diff that is just moving things around. This converts all the tests into the function
test_
form to remove global state (some test files were just one large global script!).I also removed the doc examples from the test script, since these get run and tested when the docs are built:
DiffOpt.jl/docs/make.jl
Lines 33 to 37 in 190beb8
and not all tutorials were tested anyway.
This let's us remove a bunch of packages from the tests like Flux and Plots, which should help speed things up.
I haven't addressed #195. That can wait for another PR.
Also, I noticed that there are a lot of comments in the tests with various things commented out and TODOs. I've left for now, but there are lot of open issues related to testing (#202, #109, #108, #107, #106, #102) , so the whole package could use some more work on that front.