Skip to content

(slow) operations tracker#3970

Open
joaquimg wants to merge 2 commits into
masterfrom
jg/stack
Open

(slow) operations tracker#3970
joaquimg wants to merge 2 commits into
masterfrom
jg/stack

Conversation

@joaquimg

@joaquimg joaquimg commented Apr 1, 2025

Copy link
Copy Markdown
Member

This adds the optional ability to mark all places where slow operations that allocate expression occur. Keeping the stack might be a lot of data, but it is a way to properly identify the issues instead of erroring one by one.

Possible additional functionality:
1 - also mark the operation type. A bit redundant with the stack, but might lead to summary reports.
2 - create a user friendly summary

TODO

  • add tests
  • add docs session, to be referenced in the performance issues.

@codecov

codecov Bot commented Apr 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.41353% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.25%. Comparing base (57132d8) to head (bd416ee).
⚠️ Report is 144 commits behind head on master.

Files with missing lines Patch % Lines
src/operators.jl 65.41% 46 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master    #3970      +/-   ##
===========================================
- Coverage   100.00%   99.25%   -0.75%     
===========================================
  Files           43       43              
  Lines         6076     6207     +131     
===========================================
+ Hits          6076     6161      +85     
- Misses           0       46      +46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow

odow commented May 14, 2025

Copy link
Copy Markdown
Member

I think we decided not to do this.

We have some better support with set_macro_timing , but this tutorial could still be improved:

https://jump.dev/JuMP.jl/dev/tutorials/getting_started/debugging/#Debugging-performance-problems

@joaquimg

Copy link
Copy Markdown
Member Author

I am not sure we should close yet.
I still think macros and this are very different things.
I am thinking about counting allocations here, it might be useful to rank operation types.

@odow

odow commented Jul 31, 2025

Copy link
Copy Markdown
Member

I don't know what the right approach is, but after thinking about this more I don't think that it's this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants