Conversation
dourouc05
reviewed
Aug 9, 2022
Member
Author
|
@blegat can you take a look at this? |
Contributor
|
LGTM - pretty straightforward. |
Member
Author
|
Okay. I've added a bridge from I think that shows an avenue to making the MILP bridges work, even if the reformulations are a little more work. |
Member
Author
|
I think I'm pretty happy with this, so I'll leave open for a few days if anyone wants to comment, otherwise I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1805
I've implemented these in MiniZinc: jump-dev/MiniZinc.jl#13, but I don't know if we should add to MOI.
They're a little harder to write MILP bridges for, and unlike Indicator, there isn't a range of solvers supporting a small number of constraint types (like
Indicator{GreaterThan}andIndicator{LessThan}). Instead, it's pretty arbitrary what sets you can wrap in aReified.