Skip to content

Introduce @Contract annotation #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

Introduce @Contract annotation #4741

merged 2 commits into from
Jul 18, 2025

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Jul 9, 2025

  • Introduce @Contract annotation
  • Add @Contract annotations and simplify code

Resolves #4722.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@pzygielo

This comment was marked as resolved.

@sbrannen
Copy link
Member

sbrannen commented Jul 9, 2025

contact or contract? PR description and commit messages diverge from the code.

@Contract as in nullability contracts.

I updated the PR's description, and I'm sure @marcphilipp will update the code/commits. 😉

@marcphilipp
Copy link
Member Author

Thanks for spotting my typo!

@marcphilipp marcphilipp force-pushed the marc/4722-contracts branch from 479a82c to 7ab69cf Compare July 9, 2025 12:20
@marcphilipp marcphilipp requested a review from sbrannen July 10, 2025 07:09
@marcphilipp marcphilipp force-pushed the marc/4722-contracts branch from 7ab69cf to 2e65440 Compare July 10, 2025 14:06
@marcphilipp marcphilipp force-pushed the marc/4722-contracts branch from 2e65440 to b99e301 Compare July 12, 2025 11:26
@marcphilipp
Copy link
Member Author

Sam and I went through the code in today's team call without finding any issues.

@marcphilipp marcphilipp merged commit 9794f19 into main Jul 18, 2025
14 checks passed
@marcphilipp marcphilipp deleted the marc/4722-contracts branch July 18, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce @Contract annotation for nullability constraints
3 participants