Add computeIfAbsent
variants for non-nullable types to stores
#4760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both
ExtensionContext.Store
and its backingNamespaceAwareStore
implementation allow storingnull
values, thegetOrComputeIfAbsent
methods potentially returnednull
, even ifdocumented otherwise (in case of
getOrComputeIfAbsent(Class)
inExtensionContext.Store
). Now that the API uses JSpecify's nullabilityannotations, this became more apparent and also caused
Jupiter
Extension
implementations to have to deal with values beingpotentially
null
despite their best intentions to only usegetOrComputeIfAbsent
to access a certainkey
with a function thatnever returned
null
. Therefore, this commit introduces null-safevariants called
computeIfAbsent
that treatnull
as absent inaddition to the key not being present in the backing
Map
.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations