Skip to content

Fail on classpath resource names that are blank after removing leading slash #4761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fail on classpath resource names that are blank after removing leading slash #4761

wants to merge 3 commits into from

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Jul 12, 2025 •
edited
Loading

Fixes #4752.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp self-assigned this Jul 12, 2025
@marcphilipp marcphilipp force-pushed the marc/4752-classpath-resource-name-validation branch from 3e6aa83 to e123ed6 Compare July 12, 2025 16:59
@marcphilipp marcphilipp mentioned this pull request Jul 12, 2025
Open
2 tasks
@marcphilipp marcphilipp changed the title Fail on classpath resource names that are blank after removing leading / Fail on classpath resource names that are blank after removing leading slash Jul 12, 2025
mpkorstanje
mpkorstanje reviewed Jul 12, 2025
View reviewed changes
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work as expected.

I've made a suggestion for a DiscoverySelector.toSource() method, but that could be pushed to v6.

@marcphilipp marcphilipp force-pushed the marc/4752-classpath-resource-name-validation branch 2 times, most recently from b5f7605 to 4eb5925 Compare July 13, 2025 12:07
@marcphilipp marcphilipp force-pushed the marc/4752-classpath-resource-name-validation branch from 4eb5925 to 40812a2 Compare July 15, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpkorstanje mpkorstanje mpkorstanje left review comments

@sormuras sormuras sormuras approved these changes

Assignees

@marcphilipp marcphilipp

Labels
component: Platform theme: discovery type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClasspathResourceSelector is more lenient than ClasspathResourceSource
3 participants
@marcphilipp @sormuras @mpkorstanje