-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Relocate Resource
to org.junit.platform.commons.io
package
#4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7f4df46
to
ef9c80b
Compare
...form-commons/src/main/java/org/junit/platform/commons/support/scanning/ClasspathScanner.java
Show resolved
Hide resolved
junit-platform-engine/src/main/java/org/junit/platform/engine/discovery/DiscoverySelectors.java
Show resolved
Hide resolved
org.junit.platform.commons.io.Resource
Resource
to org.junit.platform.commons.io
package
4796abc
to
9ec1c55
Compare
...form-commons/src/main/java/org/junit/platform/commons/support/scanning/ClasspathScanner.java
Show resolved
Hide resolved
b0c6cc5
to
759a037
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay - and it's always good to see "ignore" directives vanish from ArchUnit tests.
junit-platform-commons/src/main/java/org/junit/platform/commons/io/DefaultResource.java
Show resolved
Hide resolved
...form-commons/src/main/java/org/junit/platform/commons/support/scanning/ClasspathScanner.java
Outdated
Show resolved
Hide resolved
759a037
to
ebc6a85
Compare
public boolean equals(Object obj) { | ||
if (obj == this) { | ||
return true; | ||
} | ||
if (obj instanceof org.junit.platform.commons.io.Resource that) { | ||
return name.equals(that.getName()) // | ||
&& uri.equals(that.getUri()); | ||
} | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public boolean equals(Object obj) { | |
if (obj == this) { | |
return true; | |
} | |
if (obj instanceof org.junit.platform.commons.io.Resource that) { | |
return name.equals(that.getName()) // | |
&& uri.equals(that.getUri()); | |
} | |
return false; | |
} | |
public boolean equals(Object obj) { | |
return obj == this || (obj instanceof org.junit.platform.commons.io.Resource that | |
&& this.name.equals(that.getName()) && this.uri.equals(that.getUri())); | |
} |
I tend to prefer the above "this and that" pattern when using instanceof
pattern matching.
This PR introduces a new
Resource
interface in the neworg.junit.platform.commons.io
package.The old interface extends the new one so it can be used in places that now consume the new interface.
The resource finding/scanning methods in
ReflectionSupport
are now deprecated in favor of the new ones in theResourceSupport
class.Since
Predicate<...io.Resource>
andPredicate<...support.Resource>
have the same erasure, this PR introducesResourceFilter
(mimicking the existingClassFilter
) in order to be able to overload methods such asEngineDiscoveryRequestResolver.Builder.addResourceContainerSelectorResolver
.Resolves #4885.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations