Skip to content

Conversation

3coins
Copy link
Contributor

@3coins 3coins commented Oct 9, 2025

No description provided.

@3coins 3coins added the enhancement New feature or request label Oct 9, 2025
@3coins 3coins marked this pull request as ready for review October 9, 2025 03:29
Copy link
Contributor

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Feel free to cut a release after merging.

src/handler.ts Outdated
Comment on lines 14 to 18
export async function requestAPI<T>(
endPoint = '',
init: RequestInit = {}
init: RequestInit = {},
api_namespace: string = API_NAMESPACE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is a little weird because I think we can just delete API_NAMESPACE and have the endpoint path be specified through the endpoint argument. But this can be changed freely before 1.0, so this is non-blocking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in recent commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants