Skip to content

[1.x] Fix "event loop is already running" bug on Linux #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

[1.x] Fix "event loop is already running" bug on Linux #454

merged 2 commits into from
Oct 30, 2023

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Oct 30, 2023

Backports #450 to 1.x.

@dlqqq dlqqq added the bug Something isn't working label Oct 30, 2023
@dlqqq
Copy link
Collaborator Author

dlqqq commented Oct 30, 2023

please update playwright snapshots

@dlqqq
Copy link
Collaborator Author

dlqqq commented Oct 30, 2023

The above command fails because it's always using the workflow from main, which uses JupyterLab 4. I believe the only way to update snapshots in 1.x is to invoke the workflow manually in the "Actions" tab, which allows you to select the branch.

@dlqqq dlqqq closed this Oct 30, 2023
@dlqqq dlqqq reopened this Oct 30, 2023
@dlqqq dlqqq closed this Oct 30, 2023
@dlqqq dlqqq reopened this Oct 30, 2023
@dlqqq dlqqq added bug Something isn't working and removed bug Something isn't working labels Oct 30, 2023
@dlqqq dlqqq merged commit 9ee0a8b into jupyter-server:1.x Oct 30, 2023
@dlqqq dlqqq deleted the backport-450 branch October 30, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dlqqq