Add more informative error message when opening notebook and disk is full#1444
Open
nmdanny wants to merge 2 commits into
Open
Add more informative error message when opening notebook and disk is full#1444nmdanny wants to merge 2 commits into
nmdanny wants to merge 2 commits into
Conversation
krassowski
reviewed
Jul 24, 2024
| import mimetypes | ||
| import os | ||
| import re | ||
| import sqlite3 |
Collaborator
There was a problem hiding this comment.
Should there be a guard in case if Python build does no include sqlite3? There is one here:
jupyter_server/jupyter_server/services/sessions/sessionmanager.py
Lines 13 to 17 in f37967b
Author
There was a problem hiding this comment.
Good catch, I also saw that these attributes were only introduced in python 3.11, so I've made this check a bit more robust, with a string based comparison as fallback
nmdanny
force-pushed
the
improve-error-full-disk
branch
2 times, most recently
from
2e83a02 to
ad184b8
Compare
Carreau
force-pushed
the
improve-error-full-disk
branch
from
ad184b8 to
72cd10e
Compare
Contributor
|
Rebased, let's try to push this over the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when trying to load a jupyter notebook when the disk is full, you may see an error as follows:
(The reason is, opening a notebook involves SQLite updating the
last_seenfield in thenbsignaturestable, as done bymark_trusted_cells.)This MR gives a slightly more informative error in this scenario: