move argon2-cffi to optional [password] dependency for Python 3.13
#1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a temporary measure, to allow installation on free-threaded Python while CFFI is unsupported When PEP 780 lands, we can move this to a free-threaded condition, instead of a version one - big downside: `pip install jupyterlab` is incomplete on Python 3.13 if you have a password set - upside: 3.13t installation is _possible_, where it wasn't before
why is hatch fmt inconsistent with ruff?
|
going to be a little harder than I thought to test, since The maintainer-tools/base-setup action really removes a lot of flexibility and control from repos, and I don't think we should use it as much as we do for pure Python packages like this one. |
I also had to deal with this over in LibCST: https://github.com/Instagram/LibCST/blob/11d6e36450f9062b74bf82f314d42456aabf5625/.github/workflows/ci.yml#L67-L88 The Hatch issue is over here: pypa/hatch#1801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a temporary measure, to allow installation on free-threaded Python while CFFI is unsupported. Adds a test run against 3.13t.
When PEP 780 lands, we can move this to a free-threaded condition, instead of a version one. But it's possible that CFFI will be fixed before that happens.
pip install jupyterlabbecomes incomplete on Python >=3.13, as passwords cannot be set or checked without addingjupyter-server[password]dependency. Of course, only password-setting users are affected, not default tokens.The standard library does have support for scrypt now, so we could at the same time add support for scrypt passwords and use that by default. Then the degradation would be smaller, in that only password checking for already-stored argon2 passwords would be affected, instead of also losing the ability to set new ones.
xref jupyterlab/jupyterlab#16915