Fix bug in issue #1566 based on ideas in #1567. #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1567. This fixes a bug where changing the password still allowed login by a previous cookie even if the server was restarted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where changing the password still allowed login by a previous cookie even if the server was restarted.
See https://github.com/jupyter-server/jupyter_server/pull/1567/files#r2483108218 for original discussion.
I tested as follows:
\rm -rf /tmp/jup_temp && mkdir /tmp/jup_tempexport JUPYTER_CONFIG_DIR=/tmp/jup_temp/confexport XDG_CONFIG_HOME=/tmp/jup_temp/xdgexport JUPYTER_DATA_DIR=/tmp/jup_temp/dataexport JUPYTER_RUNTIME_DIR=/tmp/jup_temp/runjupyter server password # type password1jupyter serverjupyter server password # type password2jupyter server