Skip to content

Fix name when copying filenames/directories containing "-Copy" - #1604

Draft
RRosio wants to merge 1 commit into
jupyter-server:mainfrom
RRosio:copy_naming
Draft

Fix name when copying filenames/directories containing "-Copy"#1604
RRosio wants to merge 1 commit into
jupyter-server:mainfrom
RRosio:copy_naming

Conversation

@RRosio

@RRosio RRosio commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

This adds a condition to keep the original file/directory name when copying to a new directory.

@RRosio RRosio added the bug label Feb 24, 2026
@RRosio

RRosio commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

@krassowski

Copy link
Copy Markdown
Collaborator

@RRosio it should now work after restart :)

@Carreau Carreau added this to the Future milestone May 4, 2026
@Zsailer

Zsailer commented Jun 18, 2026

Copy link
Copy Markdown
Member

@RRosio thanks for fixing this!

Since we've got the same logic 4 times, do you mind making this a function and calling the function 4 times? That way, we can document and maintain the logic in a single place.

Also, let's add some unit tests to catch this case so we don't accidentally break this again in the future?

@Zsailer
Zsailer self-requested a review June 18, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants