Conversation
Per jupyter-server#899, this was out of an abundance of caution. Fixes jupyter-server#899
krassowski
reviewed
Jul 3, 2026
krassowski
left a comment
krassowski
left a comment
Collaborator
There was a problem hiding this comment.
🚀
The test failures appear related:
FAILED tests/services/contents/test_largefilemanager.py::test_bad_save[LargeFileManager-model1-HTTP 400: Bad Request (File type "notebook" is not supported for large file transfer)] - assert False
+ where False = expected_http_error(<ExceptionInfo HTTPError() tblen=2>, 400, expected_message='HTTP 400: Bad Request (File type "notebook" is not supported for large file transfer)')
FAILED tests/services/contents/test_largefilemanager.py::test_bad_save[AsyncLargeFileManager-model1-HTTP 400: Bad Request (File type "notebook" is not supported for large file transfer)] - assert False
+ where False = expected_http_error(<ExceptionInfo HTTPError() tblen=3>, 400, expected_message='HTTP 400: Bad Request (File type "notebook" is not supported for large file transfer)')
| @@ -13,143 +13,10 @@ | |||
| class LargeFileManager(FileContentsManager): | |||
| """Handle large file upload.""" | |||
Collaborator
There was a problem hiding this comment.
Would it be worth adding a future deprecation warning in the docstring and in the __init__ explaining that one can use FileContentsManager directly?
Contributor
There was a problem hiding this comment.
+1, I think a deprecation notice makes sense -- basically just say this is already the new default and we'll remove this in v3.
Contributor
|
lol, I was "like why does this sound so familiar?", then I opened the original issue :) Thanks for contributing this! Seems very sensible to me. I think some of the test failures are related though, which is strange since the code looks safe. I can help give this another look if folks are busy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #899, this was out of an abundance of caution.
Fixes #899