Skip to content

docs: Clarify fontawesome version in docs #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: Clarify fontawesome version in docs #3846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions docs/source/examples/Widget List.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
{
"cell_type": "markdown",
"metadata": {
"tags": ["remove-cell"]
"tags": [
"remove-cell"
]
},
"source": [
"[Index](Index.ipynb) - [Back](Widget%20Basics.ipynb) - [Next](Output%20Widget.ipynb)"
Expand All @@ -20,7 +22,9 @@
"cell_type": "code",
"execution_count": null,
"metadata": {
"tags": ["remove-cell"]
"tags": [
"remove-cell"
]
},
"outputs": [],
"source": [
Expand Down Expand Up @@ -415,7 +419,7 @@
" disabled=False,\n",
" button_style='', # 'success', 'info', 'warning', 'danger' or ''\n",
" tooltip='Description',\n",
" icon='check' # (FontAwesome names without the `fa-` prefix)\n",
" icon='check' # (FontAwesome v5 names without the `fa-` prefix)\n",
")"
]
},
Expand Down Expand Up @@ -931,7 +935,7 @@
" disabled=False,\n",
" button_style='', # 'success', 'info', 'warning', 'danger' or ''\n",
" tooltip='Click me',\n",
" icon='check' # (FontAwesome names without the `fa-` prefix)\n",
" icon='check' # (FontAwesome v5 names without the `fa-` prefix)\n",
")\n",
"button"
]
Expand Down Expand Up @@ -1548,7 +1552,9 @@
{
"cell_type": "markdown",
"metadata": {
"tags": ["remove-cell"]
"tags": [
"remove-cell"
]
},
"source": [
"[Index](Index.ipynb) - [Back](Widget%20Basics.ipynb) - [Next](Output%20Widget.ipynb)"
Expand Down
4 changes: 2 additions & 2 deletions python/ipywidgets/ipywidgets/widgets/widget_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ class ToggleButtons(_Selection):

icons: list
Icons to show on the buttons. This must be the name
of a font-awesome icon. See `http://fontawesome.io/icons/`
of a (v5) font-awesome icon. See `https://fontawesome.com/v5/search`
for a list of icons.

button_style: str
Expand All @@ -443,7 +443,7 @@ class ToggleButtons(_Selection):
_model_name = Unicode('ToggleButtonsModel').tag(sync=True)

tooltips = TypedTuple(Unicode(), help="Tooltips for each button.").tag(sync=True)
icons = TypedTuple(Unicode(), help="Icons names for each button (FontAwesome names without the fa- prefix).").tag(sync=True)
icons = TypedTuple(Unicode(), help="Icons names for each button (FontAwesome v5 names without the fa- prefix).").tag(sync=True)
style = InstanceDict(ToggleButtonsStyle).tag(sync=True, **widget_serialization)

button_style = CaselessStrEnum(
Expand Down
4 changes: 2 additions & 2 deletions ui-tests/tests/notebooks/widgets.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@
" disabled=False,\n",
" button_style='', # 'success', 'info', 'warning', 'danger' or ''\n",
" tooltip='Description',\n",
" icon='check' # (FontAwesome names without the `fa-` prefix)\n",
" icon='check' # (FontAwesome v5 names without the `fa-` prefix)\n",
")"
]
},
Expand Down Expand Up @@ -516,7 +516,7 @@
" disabled=False,\n",
" button_style='', # 'success', 'info', 'warning', 'danger' or ''\n",
" tooltip='Click me',\n",
" icon='check' # (FontAwesome names without the `fa-` prefix)\n",
" icon='check' # (FontAwesome v5 names without the `fa-` prefix)\n",
")\n",
"button"
]
Expand Down