Skip to content

7.x: backport #3988 Dynamic widgets registry #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 7.x
Choose a base branch
from
Open

7.x: backport #3988 Dynamic widgets registry #3992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions jupyterlab_widgets/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,31 @@ import {
import '@jupyter-widgets/base/css/index.css';
import '@jupyter-widgets/controls/css/widgets-base.css';
import { KernelMessage } from '@jupyterlab/services';
import { ISignal, Signal } from '@lumino/signaling';

const WIDGET_REGISTRY: base.IWidgetRegistryData[] = [];
class WidgetRegistry {
get widgets(): base.IWidgetRegistryData[] {
return [...this._registry];
}

push(data: base.IWidgetRegistryData) {
this._registry.push(data);
this._widgetRegistered.emit(data);
}

get widgetRegistered(): ISignal<WidgetRegistry, base.IWidgetRegistryData> {
return this._widgetRegistered;
}

private _widgetRegistered = new Signal<
WidgetRegistry,
base.IWidgetRegistryData
>(this);

private _registry: base.IWidgetRegistryData[] = [];
}

const WIDGET_REGISTRY = new WidgetRegistry();

/**
* The cached settings.
Expand Down Expand Up @@ -126,7 +149,10 @@ export function registerWidgetManager(
let wManager = Private.widgetManagerProperty.get(context);
if (!wManager) {
wManager = new WidgetManager(context, rendermime, SETTINGS);
WIDGET_REGISTRY.forEach(data => wManager.register(data));
WIDGET_REGISTRY.widgets.forEach(data => wManager.register(data));
WIDGET_REGISTRY.widgetRegistered.connect((_, data) => {
wManager.register(data);
});
Private.widgetManagerProperty.set(context, wManager);
}

Expand Down
Loading