Skip to content

Simplified footer and made its background orange #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 26, 2021
Merged

Conversation

palewire
Copy link
Collaborator

@palewire palewire commented Dec 26, 2021

Implements #542 with a new SCSS component, as well as the introduction of colors from the Jupyter brand guide.

Along the way, it fixes #531 by deleting the social links. They are so buried on the page I don't see a need to try to redesign them. We can always work the social media back into the page in the future as an enhancement. For now, I say let's close the bug.

Before:
Screenshot from 2021-12-26 07-25-55

After:
Screenshot from 2021-12-26 07-25-24

@palewire palewire added this to the Streamline the site milestone Dec 26, 2021
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of using more Jupyter colors on the site...though I feel like using the default Jupyter orange makes the footer "pop" a lot more than most footers I can think of. I find myself expecting footers to be more "muted" or pastel rather than "bright" like the Jupyter orange. Would it be not OK to use the same color but a lighter transparency or something?

I don't feel super strongly on this, but just wanted to share my gut reaction. But maybe I'm just used to the old color too much, feel free to suggest otherwise!

@palewire
Copy link
Collaborator Author

Here's what the brand guide has to say about the orange:

Jupyter Orange is the primary brand color. It should never be used in tints or shades. On any Jupyter collateral that isn’t greyscale, this orange should be present.

My take is we should hoist the flag and be loud and proud. Orange is the anthem.

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of leaning into the Jupyter brand :-) +1 from me, will hold off on merging to see if anybody objects, but I like the idea of giving this a shot and seeing how it feels over time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer tap targets are too small
3 participants