Remove ipywidgets link from the Applications section (Lab, Notebook, Voilà) #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @choldgraf since you have been merging recent PRs. |
|
I agree it is out of place. I would actually suggest we move it to a new "Widgets" section with links to demo pages of:
Since all three are under https://github.com/jupyter-widgets/ IMO the more discoverability the better. What do you think? |
|
given @krassowski 's suggestion, I encourage y'all to merge this when you're both happy with it, but otherwise I'll merge this next-week in whatever state it's in so that we take a step forward either way. |
|
(yes, my suggestion does not block merging this as-is) |
|
In that case, I'll merge as-is :-) I am a fan of "merge as soon as it's an improvement over what's there" and I think this qualifies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed we had a link to a specific ipywidgets example in try-jupyter, which seems out of place as it is listed in the "applications" section (such as Notebook, JupyterLab, or Voilà).
Proposing to remove it for clarity.