Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix client 7 and 8 compat #276

Merged
merged 15 commits into from
Feb 9, 2023
Merged

Fix client 7 and 8 compat #276

merged 15 commits into from
Feb 9, 2023

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Feb 6, 2023 •
edited
Loading

@blink1073 blink1073 added the bug label Feb 6, 2023
@blink1073 blink1073 mentioned this pull request Feb 6, 2023
Closed
@blink1073 blink1073 changed the title Fix client 8 compat Fix client 7 and 8 compat Feb 9, 2023
@blink1073 blink1073 merged commit 7bcb1c6 into jupyter:main Feb 9, 2023
@blink1073 blink1073 deleted the fix-client-8-compat branch February 9, 2023 17:11
@rpigott rpigott mentioned this pull request Feb 9, 2023
Closed
@NeilGirdhar
Copy link

Thanks for fixing this so fast. FYI, I'm having the same problem with completions: #277

@QuLogic
Copy link
Contributor

QuLogic commented Feb 20, 2023

It seems like the two enabled tests in jupyter_console/tests/test_console.py are a bit flaky. Sometimes one fails, sometimes the other fails, sometimes they both pass just fine, just from running the test suite over and over a few times. This is with Python 3.11.2, jupyter-core 5.1.0, jupyter-client 7.4.9, and prompt-toolkit 3.0.36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blink1073 @NeilGirdhar @QuLogic