Skip to content

Replace @flaky.flaky decorate with pytest marker #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace @flaky.flaky decorate with pytest marker #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions jupyter_console/tests/test_console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import tempfile
from subprocess import check_output

from flaky import flaky
import pytest

from traitlets.tests.utils import check_help_all_output
Expand All @@ -18,7 +17,7 @@
should_skip = sys.platform == "win32" or sys.version_info < (3,8) or sys.version_info[:2] == (3, 10) # noqa


@flaky
@pytest.mark.flaky
@pytest.mark.skipif(should_skip, reason="not supported")
def test_console_starts():
"""test that `jupyter console` starts a terminal"""
Expand All @@ -33,7 +32,7 @@ def test_help_output():
check_help_all_output('jupyter_console')


@flaky
@pytest.mark.flaky
@pytest.mark.skipif(should_skip, reason="not supported")
def test_display_text():
"Ensure display protocol plain/text key is supported"
Expand Down