Skip to content

Fix autograde for students with backslash in their ID #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix autograde for students with backslash in their ID #1881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a275eac
Bug fix to allow a student id containing a backslash to be autograded
sydfromm Apr 23, 2024
c3f993a
test changes for autograde
sydfromm Apr 23, 2024
b210e4f
test changes
sydfromm Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nbgrader/server_extensions/formgrader/static/js/manage_submissions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ var SubmissionUI = Backbone.View.extend({
this.$student_name.text("Please wait...");
var student = this.model.get("student");
var assignment = this.model.get("name");
$.post(base_url + "/formgrader/api/submission/" + assignment + "/" + student + "/autograde")
var encodedURI = encodeURI(base_url + "/formgrader/api/submission/" + assignment + "/" + student + "/autograde")
$.post(encodedURI)
.done(_.bind(this.autograde_success, this))
.fail(_.bind(this.autograde_failure, this));
},
Expand Down
4 changes: 4 additions & 0 deletions nbgrader/tests/apps/test_nbgrader_autograde.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,22 @@ def test_grade(self, db, course_dir):
run_nbgrader(["db", "assignment", "add", "ps1", "--db", db, "--duedate", "2015-02-02 14:58:23.948203 America/Los_Angeles"])
run_nbgrader(["db", "student", "add", "foo", "--db", db])
run_nbgrader(["db", "student", "add", "bar", "--db", db])
run_nbgrader(["db", "student", "add", "\\student1", "--db", db])

self._copy_file(join("files", "submitted-unchanged.ipynb"), join(course_dir, "source", "ps1", "p1.ipynb"))
run_nbgrader(["generate_assignment", "ps1", "--db", db])

self._copy_file(join("files", "submitted-unchanged.ipynb"), join(course_dir, "submitted", "foo", "ps1", "p1.ipynb"))
self._copy_file(join("files", "submitted-changed.ipynb"), join(course_dir, "submitted", "bar", "ps1", "p1.ipynb"))
self._copy_file(join("files", "submitted-changed.ipynb"), join(course_dir, "submitted", "\\student1", "ps1", "p1.ipynb"))
run_nbgrader(["autograde", "ps1", "--db", db])

assert os.path.isfile(join(course_dir, "autograded", "foo", "ps1", "p1.ipynb"))
assert not os.path.isfile(join(course_dir, "autograded", "foo", "ps1", "timestamp.txt"))
assert os.path.isfile(join(course_dir, "autograded", "bar", "ps1", "p1.ipynb"))
assert not os.path.isfile(join(course_dir, "autograded", "bar", "ps1", "timestamp.txt"))
assert os.path.isfile(join(course_dir, "autograded", "\\student1", "ps1", "p1.ipynb"))
assert not os.path.isfile(join(course_dir, "autograded", "\\student1", "ps1", "timestamp.txt"))

with Gradebook(db) as gb:
notebook = gb.find_submission_notebook("p1", "ps1", "foo")
Expand Down