-
Notifications
You must be signed in to change notification settings - Fork 327
Use NPM packages instead of bower for formgrader extension dependencies #1967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nbgrader/server_extensions/formgrader/static/node_modules/autosize/example | ||
nbgrader/server_extensions/formgrader/static/node_modules/autosize/src | ||
nbgrader/server_extensions/formgrader/static/node_modules/bootstrap/less | ||
nbgrader/server_extensions/formgrader/static/node_modules/bootstrap/js | ||
nbgrader/server_extensions/formgrader/static/node_modules/bootstrap/grunt | ||
nbgrader/server_extensions/formgrader/static/node_modules/jquery/external | ||
nbgrader/server_extensions/formgrader/static/node_modules/jquery/src | ||
nbgrader/server_extensions/formgrader/static/node_modules/underscore/amd | ||
nbgrader/server_extensions/formgrader/static/node_modules/underscore/cjs | ||
nbgrader/server_extensions/formgrader/static/node_modules/underscore/modules | ||
nbgrader/server_extensions/formgrader/static/node_modules/underscore/underscore-esm* | ||
nbgrader/server_extensions/formgrader/static/node_modules/underscore/underscore-node* | ||
nbgrader/server_extensions/formgrader/static/node_modules/underscore/underscore-umd* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we're using the exceptions below, we can replace all of these specific rules with a more general one:
nbgrader/server_extensions/formgrader/static/node_modules/**/*
I think this would make maintenance a tiny bit easier moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be quite similar, we would have to specify which files we want to keep instead of specifying which files we want to remove.
We probably want to keep package.json
files, readme
and some other files to know the version fetched.
The exceptions below are to prevent the following to remove these directories:
Line 13 in ab7ef18
dist/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see what you mean. I think the change I want to see goes well beyond the scope of this PR. Thanks for clarifying.
Fixes #1966
Should fix https://github.com/jupyter/nbgrader/security/dependabot/60
This PR replaces the use of deprecated
bower
by NPM.It also updates
underscore
dependency to >=1.13.1, which should fix a security error.