Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versioning mechanism and pin jupyter_client<7 #6497

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Update versioning mechanism and pin jupyter_client<7 #6497

merged 2 commits into from
Aug 2, 2022

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Aug 1, 2022

  • Use version parsing from 6.5.x branch to construct the version tuple here and allow use of 'a', 'b' and 'rc' strings in version.
  • Pin jupyter_client<7 to avoid asyncio runtime error outlined here.

@RRosio RRosio changed the title Updates Update versioning mechanism and pin jupyter_client<7 Aug 1, 2022
@RRosio RRosio marked this pull request as ready for review August 1, 2022 19:18
@RRosio
Copy link
Collaborator Author

RRosio commented Aug 1, 2022

I realize I changed the version maybe a bit prematurely here... Should I wait to make that a separate commit or would this be okay?

@echarles echarles added the bug label Aug 2, 2022
echarles
echarles approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @RRosio

@echarles echarles merged commit 44f3012 into jupyter:5.7.x Aug 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RRosio @echarles