-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test on mobile #7371
Fix flaky test on mobile #7371
Conversation
Thanks @brichet for looking into this 👍 According to the Playwright test report, the toolbar button does not seem to be visible: responsive-opener.webm |
Yes, I saw that. |
I finally managed to reproduce it locally, it seems there is again an issue with the toolbar, in this very specific case... |
Is it also reproducible in JupyterLab? |
Not that I know, but probably, it seems to be a computation issue related to the width. |
After some more tests, it may be related to the debugger icon. |
Ah so maybe it's related to #6731. The motivation behind that change was to free some space in the notebook toolbar on mobile, also since the debugger is unlikely to be used on a small screen (although it can still be opened via the menu if needed). |
Wait for the opener button to be visible in notebook toolbar.
Fixes #7370