Add active cell border padding, remove double cell padding

[andrii-i]

Add active cell left and right border padding, remove double cell left and right padding.

• Fixes Add left and right padding to active cell border #7566

Code changes

Remove notebook-specific css rules that overwrite css rules inherited from JupyterLab on left and right border padding, cell left and right padding.

User-facing changes

Active cell left and right border padding is added, double padding around cells on left and right is removed.

Screenshots

Before (2nd screenshot is at 400% zoom):

After (2nd screenshot is at 400% zoom):

[github-actions]

👈 Launch a Binder on branch andrii-i/notebook/active-cell-border-padding

[andrii-i]

please update snapshots

[krassowski]

No idea why action did not pick up your request above. Let me try:

bot please update galata snapshots

[RRosio]

Edit: Wow, I had a stale page and I did not see Mike's PR!

Hi @krassowski and @andrii-i, I saw this issue with the bot and tried looking into it. I see that the job was skipped and I thought it might be because of the author_association check that is made. I looked into the collaborators on the repo and I see neither of you are listed, which is strange because I thought you were both previously added (for triage, I believe?)... I can give it a try here to check, and I can add you as collaborators if that sounds good to you both.

bot please update galata snapshots

[RRosio]

Sorry for the noise... I see now that Andrii is a member of the Notebook Council team and that Mike's PR adds checks for comment authors

[krassowski]

Thanks for the merge @RRosio! Maybe it has to do with write permissions? I do not have them on this repo. Let me try again:

bot please update galata snapshots

@RRosio if this does not get a 👍 from bot, can you try?

[krassowski]

It worked! https://github.com/jupyter/notebook/actions/runs/13051242848

[krassowski]

It looks like snapshots are also failing on main, possibly due to release of JupyterLab 4.4.0a3 which includes Console rework:

anyways, let's wait and see

[andrii-i]

@krassowski @RRosio thank you both for looking into CI failures.

[jtpio]

Thanks all.

Updating the branch to check if #7577 helps with the CI failures.

[jtpio]

bot please update playwright snapshots

[jtpio]

Thanks @andrii-i for working on this 👍

This change seems to be having the following side-effect when selecting all cells:

For reference this is what it looks like with 7.4.0a1 (no left/right margins):

Raising this point in case folks have an opinion on which one looks better.

[andrii-i]

@jtpio Thank you for the looking into this PR and pointing out impact on selecting all cells highlight. Added screenshots to the "Before" and "After" sections of the PR description for more visibility.

This PR removes padding: unset; from WindowedPanel viewport which adds left and right padding back to it. And selecting all cells highlights cells, not a viewport. So impact on selecting all cells highlight makes sense from code changes to design system standpoint, not sure which option looks better but this PR makes this aspect of UI consistent with JupyterLab:

[jtpio]

this PR makes this aspect of UI the consistent with JupyterLab:

Right good point. We can likely go with the current state of this PR for consistency then 👍

[andrii-i]

Other than having consistent user experience, consistent user interface between lab and notebook would also reduce operational load that maintaining different Notebook user interface while JupyterLab is changing generates.

[jtpio]

Thanks!

[andrii-i]

@krassowski @RRosio @jtpio Thank you everyone for working on this.