Patch handling of singleClickNavigation #7627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
force-pushed
the
fix-single-click-navigation
branch
from
79ff9a9 to
375ffca
Compare
|
@afshin this seems to be fixing the issue, when using Firefox (138.0b5): On main / 7.4.0 notebook-singleclick-navigation-issue.mp4With this PR notebook-singleclick-navigation.mp4But it would be useful if some other people could double check too. |
This was referenced Apr 9, 2025
|
I tried these changes locally and they resolve the issue for me as well. |
|
I wasn't planning to, so if someone else is happy to, from my point of view testing is the actual work here, I was just guessing 🤓 |
|
ok I opened jupyterlab/jupyterlab#17475 then, so we can have the fix available in JupyterLab 4.4.1 and update Notebook with the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #7624
Fixes #7538