Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install netcat-openbsd in tests and update screenshots for ubuntu 24.04 #129

Merged
merged 4 commits into from
Sep 15, 2024

Conversation

manics
Copy link
Member

@manics manics commented Sep 14, 2024

In Ubuntu 22.04 netcat was an alias for netcat-openbsd. This isn't present in 22.04 which base-notebook was recently upgraded to, causing the tests to fail

In Ubuntu 22.04 `netcat` was an alias for `netcat-openbsd`. This isn't present in 22.04 which base-notebook was recently upgraded to.
@manics manics added the ci label Sep 14, 2024
Copy link

github-actions bot commented Sep 14, 2024

Binder 👈 Launch a binder notebook on this branch for commit e82cb60

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 646cedf

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a screenshot comparison error etc, maybe also related to base image change?

Can be resolved separately

@consideRatio consideRatio changed the title Install netcat-openbsd in tests Install netcat-openbsd in tests and update screenshots for ubuntu 24.04 Sep 15, 2024
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I attempted a PR title update based on the changes, go for merge if you think it was OK!

@manics
Copy link
Member Author

manics commented Sep 15, 2024

Yes, thanks!

@manics manics merged commit cf07279 into jupyterhub:main Sep 15, 2024
7 checks passed
@manics manics deleted the netcat-openbsd branch September 15, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants