Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for the session to be ready when executing a command without opening the tab #279

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cmarmo
Copy link

@cmarmo cmarmo commented Feb 7, 2025

Fixes #278.

This pull request waits for the session to be ready when creating a Kernel Output panel to execute a command.

Thank you for considering it.

@jtpio jtpio added the bug Something isn't working label Feb 14, 2025
@jtpio
Copy link
Member

jtpio commented Feb 19, 2025

Thanks @cmarmo!

#280 should already help a bit with the broken CI, but there may be still be some failing checks. Will try to have a look soon.

@cmarmo
Copy link
Author

cmarmo commented Feb 26, 2025

@jtpio I think the failing check was my responsibility: I didn't realize that the check verifies that the lines referred to into the README.md should correspond to the actual code.
I hope this is fixed now.

@jtpio
Copy link
Member

jtpio commented Feb 26, 2025

Thanks @cmarmo.

This last commit on main also seems to have failing checks: 4585387

Based on #280 (review), it looks like this extension examples repo needs to be updated to use the latest extension template to fix the remaining checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kernel output extension: Error: Session has no kernel when panel is not yet created
2 participants