Display chat users #92
Draft
+76
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brichet
commented
May 16, 2025
Comment on lines
+210
to
+219
| getMetadata(key: string): IMetadata | undefined { | ||
| return this._metadata.get(key); | ||
| } | ||
|
|
||
| setMetadata(key: string, value: PartialJSONValue) { | ||
| this.transact(() => { | ||
| this._metadata.set(key, value); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
The reason why this change has been added in this PR is for a possible usage in jupyter-ai:
- the personnas from
jupyter-aicould be displayed in this toolbar as regular collaborator, with a custom item that allows disabling it - disabling a personna should be saved in the metadata for persistence
Even if we do not add the feature described above, adding a way to get/set metadata from a frontend extension may still be useful. But it can be moved to another PR if it make more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a toolbar widget to display the connected user on the current chat.
As can be seen in the gif above, displaying all users can take up to 15 seconds (the delay between two user status updates).
It needs to wait for:
"@jupyter/collaboration": "^3"