Skip to content

Pin chromium and chromium-driver versions #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justafish merged 1 commit into from
Apr 7, 2025
Merged

Pin chromium and chromium-driver versions #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config.ddev-drupal-core-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# #ddev-generated
# This file is placed by the justafish/ddev-drupal-core-dev addon.

webimage_extra_packages: ["chromium-driver"]
ddev_version_constraint: '>=v1.23.1'
omit_containers: ["db"]
upload_dirs:
Expand Down
4 changes: 2 additions & 2 deletions docker-compose.core-dev-selenium.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
services:
chrome:
container_name: ddev-${DDEV_SITENAME}-chrome
image: seleniarm/standalone-chromium:4.1.2-20220227
image: selenium/standalone-chromium:134.0.6998.117
labels:
com.ddev.site-name: ${DDEV_SITENAME}
com.ddev.approot: $DDEV_APPROOT
Expand All @@ -22,7 +22,7 @@ services:
- ddev-global-cache:/mnt/ddev-global-cache
firefox:
container_name: ddev-${DDEV_SITENAME}-firefox
image: seleniarm/standalone-chromium:4.1.2-20220227
image: selenium/standalone-firefox:136.0.2
labels:
com.ddev.site-name: ${DDEV_SITENAME}
com.ddev.approot: $DDEV_APPROOT
Expand Down
6 changes: 6 additions & 0 deletions install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,11 @@ project_files:
- core-dev/src/Command/LintJsCommand.php
- core-dev/src/Command/LintCspellCommand.php
- core-dev/src/Command/LintCommand.php
- core-dev/src/Command/ModuleInstallCommand.php

post_install_actions:
- ddev exec sudo apt update
- ddev exec sudo apt install chromium-common=134.0.6998.35-1~deb12u1 chromium-driver=134.0.6998.35-1~deb12u1 -y --allow-downgrades
- cp core-dev/phpunit-chrome.xml ../core/phpunit.xml
- perl -pi -e "s|DRUPAL_CORE_DDEV_URL|$DDEV_PRIMARY_URL|g" ../core/phpunit.xml
- cp core-dev/.env ../core/.env
Expand All @@ -42,3 +45,6 @@ removal_actions:
fi
done
- rm -rf ../test_output
- ddev exec sudo apt update
# Revert back to default versions.
- ddev exec sudo apt install chromium-common chromium-driver -y